[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix issue #1852: manuals needs more explicit dependencies. (issue 49
From: |
janek . lilypond |
Subject: |
Re: Fix issue #1852: manuals needs more explicit dependencies. (issue 4996044) |
Date: |
Fri, 09 Sep 2011 19:19:47 +0000 |
Hi,
as usual my review will contain only questions...
Please pardon my ignorance, i don't know what this area of the code
does. However, what your patch does seems reasonable to me.
http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py
File scripts/lilypond-book.py (left):
http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py#oldcode691
scripts/lilypond-book.py:691: + '.%s' % global_options.format)
Pardon my ignorance, but what the
'.%s' %
part was doing before?
http://codereview.appspot.com/4996044/
- Fix issue #1852: manuals needs more explicit dependencies. (issue 4996044), janek . lilypond, 2011/09/09
- Re: Fix issue #1852: manuals needs more explicit dependencies. (issue 4996044),
janek . lilypond <=
- Re: Fix issue #1852: manuals needs more explicit dependencies. (issue 4996044), percival . music . ca, 2011/09/09
- Re: Fix issue #1852: manuals needs more explicit dependencies. (issue 4996044), reinhold . kainhofer, 2011/09/09
- Re: Fix issue #1852: manuals needs more explicit dependencies. (issue 4996044), percival . music . ca, 2011/09/09
- Re: Fix issue #1852: manuals needs more explicit dependencies. (issue 4996044), pkx166h, 2011/09/10
- Re: Fix issue #1852: manuals needs more explicit dependencies. (issue 4996044), janek . lilypond, 2011/09/17