lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Introduce a maximum depth for markup evaluation (issue 5032041)


From: Reinhold Kainhofer
Subject: Re: Introduce a maximum depth for markup evaluation (issue 5032041)
Date: Thu, 15 Sep 2011 22:12:18 +0200
User-agent: KMail/1.13.6 (Linux/2.6.38-11-generic; KDE/4.7.0; i686; ; )

Am Thursday, 15. September 2011, 21:57:12 schrieben Sie:
> http://codereview.appspot.com/5032041/diff/1/scm/lily.scm
> File scm/lily.scm (right):
> 
> http://codereview.appspot.com/5032041/diff/1/scm/lily.scm#newcode125
> scm/lily.scm:125: it will not terminate at all and print out a warning,
> but continue processing.")
> In the regression test the doc-text says
> "Markups have a maximum depth to prevent non-termination."
> your doc-text here seems to say something different, i.e. you'll print
> out the warning and let it carry on until Lily runs our of memory or
> whatever.  Which is right?

No, I meant that as soon as the maximum depth is reached, I return a null 
markup, so that the normal processing can continue without the markup looping 
until we run out of memory.

I'll reword the doctitle.

Cheers,
Reinhold


-- 
------------------------------------------------------------------
Reinhold Kainhofer, address@hidden, http://reinhold.kainhofer.com/
 * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
 * http://www.fam.tuwien.ac.at/, DVR: 0005886
 * LilyPond, Music typesetting, http://www.lilypond.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]