[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Fixes issue 1881 (cyclic dependency with beam calculations) (issue 50380
From: |
mtsolo |
Subject: |
Fixes issue 1881 (cyclic dependency with beam calculations) (issue 5038042) |
Date: |
Sat, 17 Sep 2011 07:53:50 +0000 |
Reviewers: ,
Message:
Hey all,
A one-line-deletion patch to fix 1881.
I think the re-introduction of length and stem-begin-position both made
this line obsolete and triggered cyclic dependencies.
I'm still not sure why these dependencies resulted in changed visual
output, but this patch seems to fix the cyclic dependency error without
causing any change in the regtests.
Cheers,
MS
Description:
Fixes issue 1881 (cyclic dependency with beam calculations)
Please review this at http://codereview.appspot.com/5038042/
Affected files:
M lily/stem.cc
Index: lily/stem.cc
diff --git a/lily/stem.cc b/lily/stem.cc
index
8a755afaa5aec63946003a19017be335f0c39b80..93ebea4c96cfaf75db438a1cbcd83b675a3f2dc9
100644
--- a/lily/stem.cc
+++ b/lily/stem.cc
@@ -160,7 +160,6 @@ Stem::set_stem_positions (Grob *me, Real se)
me->set_property ("stem-begin-position", scm_from_double (height[-d] * 2
/ staff_space));
me->set_property ("length", scm_from_double (height.length () * 2 /
staff_space));
- (void) me->extent (me, Y_AXIS);
}
/* Note head that determines hshift for upstems
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Fixes issue 1881 (cyclic dependency with beam calculations) (issue 5038042),
mtsolo <=