lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Unifies mensural ligatures with blot-diameter. (issue 5030053)


From: janek . lilypond
Subject: Re: Unifies mensural ligatures with blot-diameter. (issue 5030053)
Date: Sun, 18 Sep 2011 21:47:04 +0000

I think LGTM, but it would be great if you'd add a regtest to
demonstrate what this patch is fixing.  (i was going to write
"before/after pdfs attached to tracker issue would be priceless!" but
i've just saw that you added them - perfect!)

thanks,
Janek


http://codereview.appspot.com/5030053/diff/9001/lily/mensural-ligature.cc
File lily/mensural-ligature.cc (right):

http://codereview.appspot.com/5030053/diff/9001/lily/mensural-ligature.cc#newcode79
lily/mensural-ligature.cc:79: stencil = Lookup::beam (corrected_slope,
width * 0.5, staff_space, blotdiameter);
What does this do? (sorry for a stupid question)

http://codereview.appspot.com/5030053/diff/9001/lily/mensural-ligature.cc#newcode201
lily/mensural-ligature.cc:201: ("noteheads.sM2ligmensural").extent
(Y_AXIS).length () * 0.5
I don't get it - why is this commented?

http://codereview.appspot.com/5030053/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]