[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Glyphs for Kievan Notation (issue 4951062)
From: |
Janek Warchoł |
Subject: |
Re: Glyphs for Kievan Notation (issue 4951062) |
Date: |
Tue, 20 Sep 2011 19:39:03 +0200 |
Hi Neil,
2011/9/14 <address@hidden>:
> http://codereview.appspot.com/4951062/diff/11001/input/regression/kievan-notes.ly
> File input/regression/kievan-notes.ly (right):
>
> http://codereview.appspot.com/4951062/diff/11001/input/regression/kievan-notes.ly#newcode11
> input/regression/kievan-notes.ly:11: \override NoteHead #'stencil =
> #ly:text-interface::print
> NoteHead doesn't have an interface for 'text, so this regression test
> will spit out warnings when compiled (to see run it with
> -dcheck-internal-types).
>
> The canonical method is to use grob::interpret-markup, but this is still
> rather hackish. It would be preferable to add the infrastructure which
> switches the glyphs (if possible, a 'style setting).
I'm not sure what is your opinion on this patch currently. Do you
agree to push it if it doesn't break make, make doc and regtests? Do
you agree with my comment no.7
http://code.google.com/p/lilypond/issues/detail?id=1873#c7 ?
cheers,
Janek
- Re: Glyphs for Kievan Notation (issue 4951062), aleksandr . andreev, 2011/09/10
- Re: Glyphs for Kievan Notation (issue 4951062), aleksandr . andreev, 2011/09/10
- Re: Glyphs for Kievan Notation (issue 4951062), pkx166h, 2011/09/10
- Re: Glyphs for Kievan Notation (issue 4951062), lemzwerg, 2011/09/11
- Re: Glyphs for Kievan Notation (issue 4951062), n . puttock, 2011/09/14
- Re: Glyphs for Kievan Notation (issue 4951062),
Janek Warchoł <=
- Re: Glyphs for Kievan Notation (issue 4951062), Neil Puttock, 2011/09/20
- Re: Glyphs for Kievan Notation (issue 4951062), Neil Puttock, 2011/09/20
- Re: Glyphs for Kievan Notation (issue 4951062), Aleksandr Andreev, 2011/09/20
- Re: Glyphs for Kievan Notation (issue 4951062), Graham Percival, 2011/09/20
- Re: Glyphs for Kievan Notation (issue 4951062), Janek Warchoł, 2011/09/21
- Re: Glyphs for Kievan Notation (issue 4951062), address@hidden, 2011/09/21
- Re: Glyphs for Kievan Notation (issue 4951062), Peekay Ex, 2011/09/21
- Re: Glyphs for Kievan Notation (issue 4951062), Janek Warchoł, 2011/09/21
- Re: Glyphs for Kievan Notation (issue 4951062), Phil Holmes, 2011/09/21
- Re: Glyphs for Kievan Notation (issue 4951062), Janek Warchoł, 2011/09/22