Re: bookOutputName broken

[David Kastrup]

Benkő Pál <address@hidden> writes:

> hi David,
>
> LilyPond barfs at
>
> \book
> {
>   \bookOutputName "foo"
>
>   { a' }
> }
>
> git bisect gave me commit
> 24fdf0d37cec73564162324ab74ed5e3a6824e8c
> to blame.
>
> I don't know what to do, could you help me?

The easiest thing to do is to revert the patch.  After all, we are
shortly before release.

The patch replaces music functions returning void music with Scheme
functions that make much more sense in this context.  However, a book
block strangely does not even permit Scheme expressions inside, but has
no problem with void music.

This is rather braindead and probably an oversight.  But doing a proper
and thorough testing of all music functions I replaced is going to be
work, and as one can see, more important than checking that the function
does the same work as before (that's rather obvious) will be that its
usual mode of employment is in locations where Scheme functions can be
called just as well as music functions.  This was a bulk replacement,
and going through with a finer comb than the regtests is
time-consuming.  So reverting the commit and registering it as
"patch-needs-work" would likely be the prudent thing to do.

-- 
David Kastrup