|
| From: | reinhold . kainhofer |
| Subject: | Re: Don't blindly issue the warning (issue 5477087) |
| Date: | Wed, 14 Dec 2011 16:04:05 +0000 |
LGTM. In particular, it's a good idea to call communicate() before checking the returncode, because communicate ensures that the returncode is set... http://codereview.appspot.com/5477087/
| [Prev in Thread] | Current Thread | [Next in Thread] |