Re: Make failing

[Graham Percival]

On Mon, Dec 19, 2011 at 06:04:36PM +0100, David Kastrup wrote:
> "Phil Holmes" <address@hidden> writes:
> 
> > /home/phil/lilypond-git/lily/score-engraver.cc: In member function
> > virtual void Score_engraver::announce_grob(Grob_info)':
> > /home/phil/lilypond-git/lily/score-engraver.cc:164: error:
> > VALGRIND_PRINTF_BACKTRACE' was not declared in this scope
> > make[1]: *** [out/score-engraver.o] Error 1
> > make[1]: Leaving directory
> > /media/IntelSSD/lilypond/lilypond-git/build/lily'
> > make: *** [all] Error 2
> >
> > +    {if (info.grob ()->name () == "StemStub")
> > VALGRIND_PRINTF_BACKTRACE ("foo");
> 
> How could that have slipped by Patchy?  Graham?

Because he's got an
  #include "valgrind.h"
above that function, so VALGRIND_PRINTF_BACKTRACE is defined on my
desktop.  If Phil quoted material from a few lines higher, we'd
see whatever message g++ gives when it can't find an included
file.

I guess the thing to do is to push a patch removing whatever
debugging code Mike has in there.  I don't see much point
reverting the patch and then re-applying it.

Cheers,
- Graham