Re: Make failing

[Graham Percival]

On Mon, Dec 19, 2011 at 08:21:32PM +0100, David Kastrup wrote:
> "Phil Holmes" <address@hidden> writes:
> 
> > Yeah - warning: valgrind.h.  No such file or directory.
> 
> That's a _warning_ rather than an error?  Crazy.

I'd be *overjoyed* to make patchy compile with -Werror, but it'll
probably take about 10 hours of C++ experts cleaning up warnings.

I got as far as looking at flower/polynomial.cc, but that has a
ton of implicit signed conversions and I lost steam.  On one hand,
I guess that code works, so one could just blindly add explicit
(size_t) or (ssize_t) everywhere... but OTOH, if any signed value
slips into an array index, that's the ideal circumstances for
heisenbugs.  So I think it would be worth working on that file
more carefully than I wanted to at the moment.

Cheers,
- Graham