lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hiding /web/install


From: James
Subject: Re: [PATCH] hiding /web/install
Date: Thu, 22 Dec 2011 10:09:41 +0000

Alberto,

ccing the 'dev' list (not user) as this is more appropriate for patches etc.

2011/12/21 Alberto Simões <address@hidden>:
> Hello
>
> This patch includes more than just the title I put above: it includes the
> instructions to build the site using the patch (copy one more file) and it
> changes the way make website is called (if one copy the makefile there is no
> point in using the makefile from the git repository, or then, there is no
> point in copying -- or I missed something).
>
> The solution is not texi based. Why not? because it is a patch to solve a
> problem that is not related with the new website, but with the old.
>
> The idea is simple, just add an index.html file under /web/install/ that
> redirects to downloads.html.
>
> The makefile code can be easily copied for other folders/pages that are
> hanging out there. I did not add them because I do not know if you like the
> solution.
>
> If someone wants to test, it is easy: just backup the website, and give it a
> shot. It should not do any malicious thing.
>
> You can also test it locally, but the redirect will not work, as I specified
> a absolute path.
>
> Hope this can help.
> If not, let me know how I can change to make it better.
>
> Cheers
> ambs

Normally we use Rietveld for patch review (and we have Google Tracker
for keeping track of all the patches/enhancements/bugs etc).

If you are comfortable using Rietveld can yuo put your patch there?

I will create a tracker item for you and attach the patch, else if you
cannot (or do not want to) use Rietveld I can do that for you too,
although in the end the any corrections/comments will have to go via
me (as I'll own the Rietveld) which may be a bit tiresome for you.

Anyway the offer is there - I cannot help with the 'web code' as that
is not in my knowledge :/

Regards



-- 
--

James



reply via email to

[Prev in Thread] Current Thread [Next in Thread]