Re: make fails for staging branch

[David Kastrup]

Graham Percival <address@hidden> writes:

> On Thu, Dec 22, 2011 at 10:39:20PM +0100, David Kastrup wrote:
>> David Kastrup <address@hidden> writes:
>> 
>> > Well, I've not been able to nicely redo the merges (git address@hidden).  
>> > So I
>> > just threw everything release-related out of staging.  If you redo the
>> > merge into staging and the version number bump in staging, you should be
>> > fine.
>> 
>> I'm off to bed right now.  Hope that Patchy will find things to its
>> liking again.
>
> Apparently not; I started a rebuild ages ago.  I've never quite
> seen this, though -- rather than failing a build, make doc simply
> appears to have hung!
>
> make -C ../../Documentation/po out=www messages

Documentation/po/GNUmakefile:
TELY_FILES = $(shell ls $(depth)/Documentation/*.tely)
TELY_FILES += $(foreach l, $(LANGS), $(shell ls 
$(depth)/Documentation/$(l)/*.tely))
LSR_LYS := $(shell ls $(depth)/Documentation/snippets/*.ly)
TELY_FILES += $(LSR_LYS:%.ly=../%.ly)

        $(PYTHON) $(auxscript-dir)/texi-langutils.py -d $(outdir) -o texi.pot 
--gettext $(TELY_FILES:%.tely=../%.tely)

> ls: cannot access ../../Documentation/snippets/*.ly: No such file
> or directory

Let me summarize: TELY_FILES is a variable with deferred expansion.  It
will call its component variables when it is used.

In contrast, LSR_LYS is a variable with immediate expansion.  It will
call the shell at the time it is read in.  The action command we get
later replaces all %.tely files with ../%.tely while the %.ly files are
added to TELY_FILES in a form where they are supposed to be replaced by
../%.ly at the time TEXLY_FILES gets expanded.

What is the idea behind this sick contraption?  No idea.  Apparently
this this thing already explodes at the time LSR_LYS is encountered
first.  Does ../../Documentation/snippets/*.ly not exist?

Are we in a directory hierarchy where those files are not present?  Or
has some accident removed then?

-- 
David Kastrup