lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Doc: NR Section on Upbeats made clearer (issue 5520056)


From: janek . lilypond
Subject: Re: Doc: NR Section on Upbeats made clearer (issue 5520056)
Date: Tue, 24 Jan 2012 21:38:17 +0000

mostly LGTM


http://codereview.appspot.com/5520056/diff/7001/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):

http://codereview.appspot.com/5520056/diff/7001/Documentation/notation/rhythms.itely#newcode1358
Documentation/notation/rhythms.itely:1358: The @var{duration} can also
be any value less than a full measure:
I think it would be good without that "also".
I think the purpose of the second example is to show that partial can
contain more than one note.

http://codereview.appspot.com/5520056/diff/7001/Documentation/notation/rhythms.itely#newcode1363
Documentation/notation/rhythms.itely:1363: r4 e8 | a4 c8 b c4 |
it's a bit weird to have 3/4 time sig and 4. partial, consisting of r4
and e8 (3/4 measure doesn't divide in two parts).  but i don't think
it's that important.

http://codereview.appspot.com/5520056/diff/7001/Documentation/notation/rhythms.itely#newcode1372
Documentation/notation/rhythms.itely:1372: So @code{\partial 8} becomes;
On 2012/01/24 11:21:33, Graham Percival wrote:
grammatically I really think a full colon: is correct here.

+1

http://codereview.appspot.com/5520056/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]