lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Stops woodwind diagram info appearing on terminal (issue 5636048)


From: PhilEHolmes
Subject: Stops woodwind diagram info appearing on terminal (issue 5636048)
Date: Mon, 06 Feb 2012 12:35:57 +0000

Reviewers: dak, Graham Percival, Trevor Daniels, J_lowe,

Message:
Please review - especially changes to Documentation/notation/wind.itely

Description:
This patch has a couple of files from the LSR, which had minor changes
from my last LSR patch.  I've included them to keep the system in step.
The main changes are to /snippets/new/woodwind-diagrams-key-lists.ly
(and the associated changes to /snippets/woodwind-diagrams-key-lists.ly
created with makelsr) and Documentation/notation/wind.itely.  I'd like
someone with documentation experience to check this - I've taken out a
lilipond example, because as written it runs and dumps key information
to terminal when running make doc.  Just showing this as the code to be
run prevents this.

Please review this at http://codereview.appspot.com/5636048/

Affected files:
  M Documentation/notation/wind.itely
  M Documentation/snippets/formatting-lyrics-syllables.ly
  M Documentation/snippets/hymn-template.ly
  M Documentation/snippets/new/woodwind-diagrams-key-lists.ly
  M Documentation/snippets/partcombine-and-autobeamoff.ly
  M Documentation/snippets/woodwind-diagrams-key-lists.ly


Index: Documentation/notation/wind.itely
diff --git a/Documentation/notation/wind.itely b/Documentation/notation/wind.itely index a9725fd7172391e37d629c06f0927ae5471701cf..a935aa121da5f79d712eb7bc5493ed86b9359386 100644
--- a/Documentation/notation/wind.itely
+++ b/Documentation/notation/wind.itely
@@ -393,14 +393,10 @@ c1^\markup {
 @end lilypond

 The list of all possible keys and settings for a given instrument
-can be displayed on the console or in the log file, although they
-will not show up in the music output:
-
address@hidden,quote]
-
-#(print-keys-verbose 'flute)
-
address@hidden lilypond
+can be displayed on the console using
address@hidden(print-keys-verbose 'flute)} or in the log file using
address@hidden(print-keys-verbose 'flute (current-error-port))}, although
+they will not show up in the music output.

 New diagrams can be created by following the patterns in
 @file{scm/define-woodwind-diagrams.scm} and
Index: Documentation/snippets/formatting-lyrics-syllables.ly
diff --git a/Documentation/snippets/formatting-lyrics-syllables.ly b/Documentation/snippets/formatting-lyrics-syllables.ly index fa99151b8e5b7ee8a1c699a04764d54dcd685c18..f64e9f012a2123236fc906850b62d53a0a0698d8 100644
--- a/Documentation/snippets/formatting-lyrics-syllables.ly
+++ b/Documentation/snippets/formatting-lyrics-syllables.ly
@@ -16,7 +16,6 @@ zu formatieren.

 "
   doctitlede = "Silben im Gesangstext formatieren"
-
 %%  Translation of GIT committish: d9d1da30361a0bcaea1ae058eb1bc8dd3a5b2e4c
   texidocfr = "
Le mode markup permet d'individualiser la mise en forme de certaines syllabes.
Index: Documentation/snippets/hymn-template.ly
diff --git a/Documentation/snippets/hymn-template.ly b/Documentation/snippets/hymn-template.ly index d2d680e43dfea62090a156715ec1e9f0c6aa7c6a..b8af195da3061d7efafc9ed554bbdc6866882ef8 100644
--- a/Documentation/snippets/hymn-template.ly
+++ b/Documentation/snippets/hymn-template.ly
@@ -27,7 +27,6 @@ strofe come testo separato sotto la musica.

 "
   doctitleit = "Modello per inno"
-
%% Translation of GIT committish: ab9e3136d78bfaf15cc6d77ed1975d252c3fe506

   texidocde = "
Index: Documentation/snippets/new/woodwind-diagrams-key-lists.ly
diff --git a/Documentation/snippets/new/woodwind-diagrams-key-lists.ly b/Documentation/snippets/new/woodwind-diagrams-key-lists.ly index bdb803cfd9c04e5c101deb8e69f33eda1b961672..0fcdecac584d302b2c221f6bc607e8327dab298b 100644
--- a/Documentation/snippets/new/woodwind-diagrams-key-lists.ly
+++ b/Documentation/snippets/new/woodwind-diagrams-key-lists.ly
@@ -7,19 +7,24 @@
 The snippet below produces a list of all possible keys and key
 settings for woodwind diagrams as defined in
 @file{scm/define-woodwind-diagrams.scm}.  The list will be displayed
-on the console and in the log file, but not in the music.
+in the log file, but not in the music.  If output to the console
+is wanted, omit the @code{(current-error-port)} from the commands.
 "
   doctitle = "Woodwind diagrams key lists"
 }

-#(print-keys-verbose 'piccolo)
-#(print-keys-verbose 'flute)
-#(print-keys-verbose 'flute-b-extension)
-#(print-keys-verbose 'oboe)
-#(print-keys-verbose 'clarinet)
-#(print-keys-verbose 'bass-clarinet)
-#(print-keys-verbose 'low-bass-clarinet)
-#(print-keys-verbose 'saxophone)
-#(print-keys-verbose 'baritone-saxophone)
-#(print-keys-verbose 'bassoon)
-#(print-keys-verbose 'contrabassoon)
+#(print-keys-verbose 'piccolo (current-error-port))
+#(print-keys-verbose 'flute (current-error-port))
+#(print-keys-verbose 'flute-b-extension (current-error-port))
+#(print-keys-verbose 'tin-whistle (current-error-port))
+#(print-keys-verbose 'oboe (current-error-port))
+#(print-keys-verbose 'clarinet (current-error-port))
+#(print-keys-verbose 'bass-clarinet (current-error-port))
+#(print-keys-verbose 'low-bass-clarinet (current-error-port))
+#(print-keys-verbose 'saxophone (current-error-port))
+#(print-keys-verbose 'soprano-saxophone (current-error-port))
+#(print-keys-verbose 'alto-saxophone (current-error-port))
+#(print-keys-verbose 'tenor-saxophone (current-error-port))
+#(print-keys-verbose 'baritone-saxophone (current-error-port))
+#(print-keys-verbose 'bassoon (current-error-port))
+#(print-keys-verbose 'contrabassoon (current-error-port))
Index: Documentation/snippets/partcombine-and-autobeamoff.ly
diff --git a/Documentation/snippets/partcombine-and-autobeamoff.ly b/Documentation/snippets/partcombine-and-autobeamoff.ly index bf5fb3e519f6c174cca955b991465fdd9f6d0f31..fb3f88f3409a22923d0ebf63d4045387a98a4ba8 100644
--- a/Documentation/snippets/partcombine-and-autobeamoff.ly
+++ b/Documentation/snippets/partcombine-and-autobeamoff.ly
@@ -47,7 +47,6 @@ necesario hacer tres llamadas a @code{\\autoBeamOff}.

 "
   doctitlees = "Partcombine y autoBeamOff"
-
%% Translation of GIT committish: ab9e3136d78bfaf15cc6d77ed1975d252c3fe506

   texidocde = "
@@ -79,7 +78,6 @@ wenn man es mit @code{\\partcombine} verwendet, muss @code{\\autoBeamOff}
 "
 doctitlede = "Partcombine und autoBeamOff"

-
 %% Translation of GIT committish: 3b125956b08d27ef39cd48bfa3a2f1e1bb2ae8b4
   texidocfr = "
 La fonction @code{\\autoBeamOff} dans le cadre d'un
Index: Documentation/snippets/woodwind-diagrams-key-lists.ly
diff --git a/Documentation/snippets/woodwind-diagrams-key-lists.ly b/Documentation/snippets/woodwind-diagrams-key-lists.ly index 0f0d6f355462ee5cd79bd101d49b927e358576bd..075f6e814c767597dcba673e95c8321402e2e9b0 100644
--- a/Documentation/snippets/woodwind-diagrams-key-lists.ly
+++ b/Documentation/snippets/woodwind-diagrams-key-lists.ly
@@ -50,20 +50,25 @@ sous forme de musique.
 The snippet below produces a list of all possible keys and key
 settings for woodwind diagrams as defined in
 @file{scm/define-woodwind-diagrams.scm}.  The list will be displayed
-on the console and in the log file, but not in the music.
+in the log file, but not in the music.  If output to the console
+is wanted, omit the @code{(current-error-port)} from the commands.
 "
   doctitle = "Woodwind diagrams key lists"
 } % begin verbatim


-#(print-keys-verbose 'piccolo)
-#(print-keys-verbose 'flute)
-#(print-keys-verbose 'flute-b-extension)
-#(print-keys-verbose 'oboe)
-#(print-keys-verbose 'clarinet)
-#(print-keys-verbose 'bass-clarinet)
-#(print-keys-verbose 'low-bass-clarinet)
-#(print-keys-verbose 'saxophone)
-#(print-keys-verbose 'baritone-saxophone)
-#(print-keys-verbose 'bassoon)
-#(print-keys-verbose 'contrabassoon)
+#(print-keys-verbose 'piccolo (current-error-port))
+#(print-keys-verbose 'flute (current-error-port))
+#(print-keys-verbose 'flute-b-extension (current-error-port))
+#(print-keys-verbose 'tin-whistle (current-error-port))
+#(print-keys-verbose 'oboe (current-error-port))
+#(print-keys-verbose 'clarinet (current-error-port))
+#(print-keys-verbose 'bass-clarinet (current-error-port))
+#(print-keys-verbose 'low-bass-clarinet (current-error-port))
+#(print-keys-verbose 'saxophone (current-error-port))
+#(print-keys-verbose 'soprano-saxophone (current-error-port))
+#(print-keys-verbose 'alto-saxophone (current-error-port))
+#(print-keys-verbose 'tenor-saxophone (current-error-port))
+#(print-keys-verbose 'baritone-saxophone (current-error-port))
+#(print-keys-verbose 'bassoon (current-error-port))
+#(print-keys-verbose 'contrabassoon (current-error-port))





reply via email to

[Prev in Thread] Current Thread [Next in Thread]