Re: Allow music with layout instructions in output definitions. (issue 5701049)

[dak]

Reviewers: janek,

Message:
On 2012/02/27 22:23:15, janek wrote:

> However, the following example doesn't work (it doesn't produce any
warning,
> either):

> \score {
>    \new Staff { b b }
>    \layout { \override NoteHead #'color = #red }
> }

> Is this intended?  I hoped that it would be possible to do this.

Totally elusive bug that also afflicted \settingsFrom.  Fixed

> I even hoped that something like this will be possible:

> \score { <<
>      \new Voice { b b }
>      \new Voice = "aa" { b b }
>    >>
>    \layout { \override aa.NoteHead #'color = #red }
> }

> but the results are strange: not only does it not compile, but it
gives an
> unusual error:

It is nonsense since aa is not the type but the id of a context and
can't be meddled with in a layout definition.

Try \new Voice = "aa" \with { \settingsFrom \override NoteHead #'color
#red } { ...
instead.

The code for the warning was, however, malformed.  Fixed.

Description:
Allow music with layout instructions in output definitions.

This allows things like

  \layout { \accidentalStyle modern }

or

  \midi { \tempo 4 = 80 }

to work as intended.

Please review this at http://codereview.appspot.com/5701049/

Affected files:
  M lily/context-def.cc
  M lily/include/context-def.hh
  M lily/parser.yy
  M ly/declarations-init.ly
  M scm/lily-library.scm