lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: beam.cc:pure-rest-collision-callback Place on staff lines; issue 246


From: dak
Subject: Re: beam.cc:pure-rest-collision-callback Place on staff lines; issue 2468 (issue 6035053)
Date: Sun, 15 Apr 2012 15:32:10 +0000

On 2012/04/15 15:20:13, Graham Percival wrote:
wow, looks very nice and simple.  I vote for pushing immediately, but
please
wait for at least one other such vote (or a countdown).

if max/min trigger, rint is applied to some rest_max_pos.  It would
appear that it should rather apply only to the calculated mean.

The calculated mean uses the current rounding mode.  If it is IEEE
rounding, this means round to even: (1+2)/2.0 will be rounded to 2.0,
and (2+3)/2.0 will be rounded to 2.0 as well.  That looks suspicious to
me, like every second staff line will get avoided for values right in
between.

http://codereview.appspot.com/6035053/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]