lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: beam.cc:pure-rest-collision-callback Place on staff lines; issue 246


From: mike
Subject: Re: beam.cc:pure-rest-collision-callback Place on staff lines; issue 2468 (issue 6035053)
Date: Wed, 25 Apr 2012 06:29:02 +0000


http://codereview.appspot.com/6035053/diff/16001/lily/beam.cc
File lily/beam.cc (right):

http://codereview.appspot.com/6035053/diff/16001/lily/beam.cc#newcode1328
lily/beam.cc:1328: return scm_from_double (0.0);
On 2012/04/25 06:21:29, Keith wrote:
It would seem we do not want an early return in this case; if the beam
direction
is not yet know, we would prefer to estimate the rest position to
returning the
wrong value.
But this condition was added recently, with the fix for issue 774.

What would the "wrong value" be here?

http://codereview.appspot.com/6035053/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]