Re: Change \bendAfter and \rightHandFinger into event functions (issue 6102045)

[dak]

Reviewers: Graham Percival,


http://codereview.appspot.com/6102045/diff/1/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):

http://codereview.appspot.com/6102045/diff/1/Documentation/notation/fretted-strings.itely#newcode1589
Documentation/notation/fretted-strings.itely:1589: <e\rightHandFinger 2>
On 2012/04/23 03:45:38, Graham Percival wrote:
> oh god.  At one point, we tried to eliminate all #-less numbers to
avoid
> confusion like this.

> I know that you're proud of parser work which lets us write a bare 2
here, but I
> fear this would lead to user confusion and not be a net positive.
Could we
> leave the #2 > there?

Done.

Description:
Change \bendAfter and \rightHandFinger into event functions

Please review this at http://codereview.appspot.com/6102045/

Affected files:
  M Documentation/notation/expressive.itely
  M Documentation/notation/fretted-strings.itely
  M ly/music-functions-init.ly


Index: Documentation/notation/expressive.itely
diff --git a/Documentation/notation/expressive.itely  
b/Documentation/notation/expressive.itely
index  
0d86f3e639dd7b1344726ce61b11e680dd37e088..d38175ce4858544b5b34f441de1c4ab1a93ef64e  
100644
--- a/Documentation/notation/expressive.itely
+++ b/Documentation/notation/expressive.itely
@@ -989,18 +989,14 @@ indicates the pitch interval that the fall or doit  
will extend
 @emph{beyond} the main note.

 @lilypond[verbatim,quote,relative=2]
-c2-\bendAfter #+4
-c2-\bendAfter #-4
-c2-\bendAfter #+6.5
-c2-\bendAfter #-6.5
-c2-\bendAfter #+8
-c2-\bendAfter #-8
+c2\bendAfter #+4
+c2\bendAfter #-4
+c2\bendAfter #+6.5
+c2\bendAfter #-6.5
+c2\bendAfter #+8
+c2\bendAfter #-8
 @end lilypond

-The dash @code{-} immediately preceding the @code{\bendAfter}
-command is @emph{required} when writing falls and doits.
-
-
 @snippets

 @lilypondfile[verbatim,quote,texidoc,doctitle]
Index: Documentation/notation/fretted-strings.itely
diff --git a/Documentation/notation/fretted-strings.itely  
b/Documentation/notation/fretted-strings.itely
index  
e8deaafb8c9402363d8e4f9195a39416d2d4c82d..b9267e33d050aa0f8416c2d4051da80a8b7e7103  
100644
--- a/Documentation/notation/fretted-strings.itely
+++ b/Documentation/notation/fretted-strings.itely
@@ -1580,24 +1580,24 @@ Right-hand fingerings @var{p-i-m-a} must be entered  
within a
 chord construct @code{<>} for them to be printed in the score,
 even when applied to a single note.

address@hidden @strong{must} be a hyphen before
address@hidden@bs{}rightHandFinger} and a space before the closing @code{>}.}
address@hidden the number is entered in Scheme notation, remember to append
+a space before following it with a closing @code{>} or similar.}

 @lilypond[quote,verbatim,relative=0]
 \clef "treble_8"
-<c-\rightHandFinger #1 >4
-<e-\rightHandFinger #2 >
-<g-\rightHandFinger #3 >
-<c-\rightHandFinger #4 >
-<c,-\rightHandFinger #1 e-\rightHandFinger #2
- g-\rightHandFinger #3 c-\rightHandFinger #4 >1
+<c\rightHandFinger #1 >4
+<e\rightHandFinger #2 >
+<g\rightHandFinger #3 >
+<c\rightHandFinger #4 >
+<c,\rightHandFinger #1 e\rightHandFinger #2
+ g\rightHandFinger #3 c\rightHandFinger #4 >1
 @end lilypond

 For convenience, you can abbreviate @code{\rightHandFinger} to something
 short, for example @code{RH},

 @example
-#(define RH rightHandFinger)
+RH=#rightHandFinger
 @end example


Index: ly/music-functions-init.ly
diff --git a/ly/music-functions-init.ly b/ly/music-functions-init.ly
index  
80c3020ac04b7a2574ad72b85e59cad45edffaac..59a11264f7c741d84d3c854494adfd3f8cdfad2c  
100644
--- a/ly/music-functions-init.ly
+++ b/ly/music-functions-init.ly
@@ -178,7 +178,7 @@ barNumberCheck =
                                         cbn n))))))

 bendAfter =
-#(define-music-function (parser location delta) (real?)
+#(define-event-function (parser location delta) (real?)
    (_i "Create a fall or doit of pitch interval @var{delta}.")
    (make-music 'BendAfterEvent
               'delta-step delta))
@@ -952,7 +952,7 @@ for time signatures of @var{time-signature}.")
    (revert-time-signature-setting time-signature))

 rightHandFinger =
-#(define-music-function (parser location finger) (number-or-string?)
+#(define-event-function (parser location finger) (number-or-string?)
    (_i "Apply @var{finger} as a fingering indication.")

    (make-music