Re: Doc: NR 1.2.3 Expl. manual accidentals + cadenzas (issue 5976056)

[pkx166h]

Reviewers: Graham Percival, Trevor Daniels,

Message:
Thanks Trevor, this one slipped past my radar.


http://codereview.appspot.com/5976056/diff/1/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):

http://codereview.appspot.com/5976056/diff/1/Documentation/notation/rhythms.itely#newcode1415
Documentation/notation/rhythms.itely:1415: @cindex beams, unmetered
music
On 2012/04/01 22:09:16, Trevor Daniels wrote:
> I think there should be index entries leading to this section starting
from both
> bar line and bar number, as before.  Why delete them?
It was an oversight inasmuch as I meant to put back bar line as I have
'bar numbers. Thanks for spotting.

I deleted the 'turning off' reference as that isn't what cadenza's do,
they force LP to 'ignore' them but not turn them off.

http://codereview.appspot.com/5976056/diff/1/Documentation/notation/rhythms.itely#newcode1422
Documentation/notation/rhythms.itely:1422: In metered music, measures
are calculated automatically for bar lines
On 2012/04/01 22:09:16, Trevor Daniels wrote:
> I don't know what "calculating measures" means.  Perhaps say, "In
metered music
> bar lines are inserted and bar numbers are calculated automatically."

Done.

http://codereview.appspot.com/5976056/diff/1/Documentation/notation/rhythms.itely#newcode1450
Documentation/notation/rhythms.itely:1450: Cadenzas are treated as a
@q{single measure} of music, even if one or
On 2012/04/01 22:09:16, Trevor Daniels wrote:
> No, they can be shorter and within a measure of music.  Perhaps say,
"A new bar
> is never started within a cadenza, even if one or more @code{\bar}
commands are
> inserted within it."

Done.

http://codereview.appspot.com/5976056/diff/1/Documentation/notation/rhythms.itely#newcode1478
Documentation/notation/rhythms.itely:1478: These commands affect all
staves in the score, even when placed in just
On 2012/04/01 22:09:16, Trevor Daniels wrote:
> We conventionally use the term "predefined commands" to refer to
commands
> defined in ly/property-init.ly.

Of course! Thanks. Done.

http://codereview.appspot.com/5976056/diff/1/Documentation/notation/rhythms.itely#newcode1512
Documentation/notation/rhythms.itely:1512: In unmetered music, line and
page breaks will only occur at a bar line,
On 2012/04/01 22:09:16, Trevor Daniels wrote:
> This is true generally, not just in unmetered music.
> "Automatic line and page breaks are inserted only at bar lines, so
@q{invisible}
> bar lines will need to be inserted manually in long stretches of
unmetered music
> to permit breaking:"

Done.

Description:
Doc: NR 1.2.3 Expl. manual accidentals + cadenzas

Issue 2438

Added notes about using manual accidentals for reminder accidentals
when using \cadenzaOn.

Add it to note about manual beams.

Tidied up some 'third person' references and tightened up sentences
along with some 'long' @cindex entries.

Added an @ref{}

Please review this at http://codereview.appspot.com/5976056/

Affected files:
  M Documentation/notation/rhythms.itely


Index: Documentation/notation/rhythms.itely
diff --git a/Documentation/notation/rhythms.itely  
b/Documentation/notation/rhythms.itely
index  
680e96c4fdeb78cc58dfb216915a8b60c463eab1..0052f78f23223f570dc2143367dceb568e8c8576  
100644
--- a/Documentation/notation/rhythms.itely
+++ b/Documentation/notation/rhythms.itely
@@ -1401,21 +1401,31 @@ r8 e,8 | a4 c8 b[ c b] |
 @node Unmetered music
 @unnumberedsubsubsec Unmetered music

address@hidden bar lines, turning off
address@hidden bar numbering, turning off
 @cindex cadenza
address@hidden cadenza, beams
address@hidden cadenza, accidentals
address@hidden cadenza, bar lines
address@hidden cadenza, bar numbers
 @cindex unmetered music
address@hidden unmetered music, beams
address@hidden unmetered music, accidentals
address@hidden unmetered music, bar lines
address@hidden unmetered music, bar numbers
address@hidden accidentals, cadenzas
address@hidden accidentals, unmetered music
address@hidden beams, cadenzas
address@hidden beams, unmetered music

 @funindex \cadenzaOn
 @funindex cadenzaOn
 @funindex \cadenzaOff
 @funindex cadenzaOff

-Bar lines and bar numbers are calculated automatically.  For
-unmetered music (some cadenzas, for example), this is not desirable.
-To turn off automatic calculation of bar lines and bar numbers,
-use the command @code{\cadenzaOn}, and use @code{\cadenzaOff}
-to turn them on again.
+In metered music bar lines are inserted and bar numbers are calculated
+automatically. In unmetered music (i.e. cadenzas), this is not
+desirable and can be @q{switched off} using the command
address@hidden, then @q{switched back on} at the appropriate place
+using @code{\cadenzaOff}.

 @lilypond[verbatim,relative=2,quote]
 c4 d e d
@@ -1426,8 +1436,7 @@ c4 c d8[ d d] f4 g4.
 d4 e d c
 @end lilypond

-Bar numbering is resumed at the end of the cadenza as if the
-cadenza were not there:
+Bar numbering is resumed at the end of the cadenza.

 @lilypond[verbatim,relative=2,quote]
 % Show all bar numbers
@@ -1440,29 +1449,37 @@ c4 c d8[ d d] f4 g4.
 d4 e d c
 @end lilypond

address@hidden beams, in cadenzas
address@hidden beams, in unmetered music
address@hidden cadenza, with beams
address@hidden unmetered music, with beams
+A new bar is never started within a cadenza, even if one or more
address@hidden commands are inserted within it.  Therefore, reminder
+accidentals will need to be added manually.  See @ref{Accidentals}.

-Automatic beaming is disabled by @code{\cadenzaOn} and enabled
-by @code{\cadenzaOff}.  Therefore, all beaming in cadenzas
-must be entered manually (@ref{Manual beams}).
address@hidden,relative=2,quote]
+c4 d e d
+\cadenzaOn
+cis4 d cis d
+\bar "|"
+cis4 d cis! d
+\cadenzaOff
+\bar "|"
address@hidden lilypond
+
+Automatic beaming is disabled by @code{\cadenzaOn}. Therefore, all
+beaming in cadenzas must be entered manually. See @ref{Manual beams}.

 @lilypond[verbatim,relative=2,quote]
 \repeat unfold 8 { c8 }
 \cadenzaOn
-\repeat unfold 5 { c8 }
+cis8 c c c c
 \bar"|"
+c8 c c
 \cadenzaOff
 \repeat unfold 8 { c8 }
 @end lilypond

-Note that these predefined commands affect all staves in the
-score, even when they are placed in just one @code{Voice}
-context.  To change this, move the @code{Timing_translator}
-from the @code{Score} context to the @code{Staff} context, as
-shown in @ref{Polymetric notation}.
+These predefined commands affect all staves in the score, even when
+placed in just one @code{Voice} context.  To change this, move the
address@hidden from the @code{Score} context to the
address@hidden context.  See @ref{Polymetric notation}.

 @predefined
 @code{\cadenzaOn},
@@ -1476,35 +1493,33 @@ Music Glossary:
 Notation Reference:
 @ref{Visibility of objects},
 @ref{Polymetric notation},
address@hidden beams}.
address@hidden beams},
address@hidden

 Snippets:
 @rlsr{Rhythms}.

address@hidden cadenza line breaks
address@hidden cadenza page breaks
address@hidden cadenza, line breaks
address@hidden cadenza, page breaks
 @cindex unmetered music, line breaks
 @cindex unmetered music, page breaks
 @cindex breaks in unmetered music
address@hidden line breaks in cadenzas
address@hidden page breaks in cadenzas
address@hidden line breaks in unmetered music
address@hidden page breaks in unmetered music
address@hidden line breaks, cadenzas
address@hidden page breaks, cadenzas
address@hidden line breaks, unmetered music
address@hidden page breaks, unmetered music

 @knownissues
-LilyPond will insert line breaks and page breaks only at a
-bar line.  Unless the unmetered music ends before the end of the
-staff line, you will need to insert invisible bar lines with
+Automatic line and page breaks are inserted only at bar lines, so
address@hidden bar lines will need to be inserted manually in long
+stretches of unmetered music to permit breaking:

 @example
 \bar ""
 @end example

address@hidden
-to indicate where breaks can occur.
-
-You should explicitly create a @code{Voice} context when starting a
-piece with @code{\cadenzaOn}, otherwise strange errors may occur.
+Explicitly create a @code{Voice} context when starting a piece with
address@hidden, else unexpected errors may occur.

 @example
 \new Voice @{