lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix MIDI output for Kievan (issue 6193043)


From: Carl . D . Sorensen
Subject: Re: Fix MIDI output for Kievan (issue 6193043)
Date: Fri, 04 May 2012 02:59:06 +0000

Looks like it works, but I think it can (and should) be simplified.  If
it can't, then LGTM.


http://codereview.appspot.com/6193043/diff/1/ly/performer-init.ly
File ly/performer-init.ly (right):

http://codereview.appspot.com/6193043/diff/1/ly/performer-init.ly#newcode49
ly/performer-init.ly:49: \consists "Staff_performer"
Do these \consists need to be added?  Does the \alias Staff bring in the
Staff_performer and the Key_performer from the Staff Performer_group?

http://codereview.appspot.com/6193043/diff/1/ly/performer-init.ly#newcode88
ly/performer-init.ly:88: \consists "Dynamic_performer"
Again, don't the performers from the Voice performer group get added
automatically by the \alias Voice?

http://codereview.appspot.com/6193043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]