Re: [XY]-core-extent and general_alignment (issue 2613) (issue 6308093)

[Han-Wen Nienhuys]

This patch seems to be for solving a lyrics related problem. It would
be nice if this wouldn't require overhaul of the core data structures
of LilyPond. Each and every graphic object has a dimension-cache, so
you're adding a core-extent (as opposed to the normal extent) to each
object. Does that make sense?  I think it would be much better if you
could solve this problem while only touching the lyrics related code.

On Tue, Jun 19, 2012 at 2:59 PM,  <address@hidden> wrote:
> Reviewers: MikeSol, joeneeman,
>
> Message:
> A pdf showing what this patch does is attached to tracker issue:
> http://code.google.com/p/lilypond/issues/detail?id=2613#c2
>
> Please review!
>
> Description:
> [XY]-core-extent and general_alignment (issue 2613)
>
> This adds a versatile method for specifying alignment of grobs.
>
> Please review this at http://codereview.appspot.com/6308093/
>
> Affected files:
>  M lily/dimension-cache.cc
>  M lily/grob.cc
>  M lily/include/dimension-cache.hh
>  M lily/include/grob.hh
>  M lily/include/self-alignment-interface.hh
>  M lily/self-alignment-interface.cc
>  M scm/define-grob-properties.scm
>  M scm/define-grobs.scm
>
>
>
> _______________________________________________
> lilypond-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/lilypond-devel



-- 
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen