lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Regtest changes phase 1 (issue 6454121)


From: PhilEHolmes
Subject: Regtest changes phase 1 (issue 6454121)
Date: Wed, 08 Aug 2012 15:49:48 +0000

Reviewers: Graham Percival,

Message:
Please review initial regtest updates

Description:
This is just 3 files to start with, to check the principle of adding
considerable extra descriptive text to the regtest to make it mode
apparent what is being tested.  These were the 3 lowest marked regtests
in the recent review.

Please review this at http://codereview.appspot.com/6454121/

Affected files:
  M input/regression/context-mod-with.ly
  M input/regression/markup-user.ly
  M input/regression/relative-repeat.ly


Index: input/regression/context-mod-with.ly
diff --git a/input/regression/context-mod-with.ly b/input/regression/context-mod-with.ly index 68ae7af707a634939ac112ae61c8e2db3543d8b4..ae70776c9f777eadc91837e13e1b825590e3e702 100644
--- a/input/regression/context-mod-with.ly
+++ b/input/regression/context-mod-with.ly
@@ -12,34 +12,55 @@ ctxmod = \with {
   \override StaffSymbol #'line-count = 4
 }

+\layout {
+  \context {
+    \Score
+    \remove "Mark_engraver"
+    \remove "Staff_collecting_engraver"
+  }
+  \context {
+    \Staff
+    \consists "Mark_engraver"
+    \consists "Staff_collecting_engraver"
+  }
+}
+
+
 music = \relative c'' { \key fis \minor c1 d e }

 \score { <<
-  % No modifications:
-  \new Staff { \music }
-  % Some context modifications manually written in a \with block
+  \override Score.RehearsalMark #'self-alignment-X = #LEFT
+  \override Score.RehearsalMark #'font-size = #-2
+  \new Staff { \mark \markup { No modifications } \music }
   \new Staff \with {
     \remove "Time_signature_engraver"
     \consists "Ambitus_engraver"
     \override StaffSymbol #'line-count = 4
-  } { \music }
-  % The same mods as direct value of \with
-  \new Staff \with \ctxmod { \music }
-  % Mods as part of a \with block
-  \new Staff \with { \ctxmod } { \music }
-  % Mods before a context mod in a with block are working:
+  } {
+    \mark
+    \markup { "Remove time sig, add ambitus, set staff to 4 lines" }
+    \music }
+  \new Staff \with \ctxmod {
+    \mark \markup { "The same mods using a variable" } \music
+  }
+  \new Staff \with { \ctxmod } {
+    \mark \markup { "The same mods using a variable and \with" }
+    \music
+  }
   \new Staff \with {
     \remove "Clef_engraver"
     \ctxmod
-  } { \music }
-  % Mods before and after a context mod in a with block are working:
+  } {
+    \mark
+ \markup { "Remove clef and use variable to add other changes as above" }
+    \music
+  }
   \new Staff \with {
     \remove "Clef_engraver"
     \ctxmod
     \remove "Key_engraver"
-  } { \music }
- % Mods can be inserted instead of a \with block (i.e. \with is not required)
-  \new Staff \ctxmod { \music }
-  \new Staff { \music }
+  } { \mark \markup { "Also remove clef and key" } \music }
+ \new Staff \ctxmod { \mark \markup { "The same mods as staff 2" } \music }
+  \new Staff { \mark \markup { "Back to default" } \music }
 >>
 }
Index: input/regression/markup-user.ly
diff --git a/input/regression/markup-user.ly b/input/regression/markup-user.ly index 8c4afdf6acc504826de2e4a1b121bf98998b491b..db8bd1b00afcad8e1d652608c7d3a191bdbe70a8 100644
--- a/input/regression/markup-user.ly
+++ b/input/regression/markup-user.ly
@@ -1,13 +1,9 @@
-
 \header {
   texidoc = "Users may define non-standard markup commands using
 the @code{define-markup-command} scheme macro."
 }

-
 \layout { ragged-right = ##t }
-
-

 \version "2.14.0"

@@ -17,8 +13,7 @@ the @code{define-markup-command} scheme macro."

 \score{
   {
-    c''-\markup \upcase #"hello world"
-                               % produces a "HELLO WORLD" markup
+    c''-\markup \upcase #"hello world in upper case"
   }

   \layout {
@@ -27,5 +22,4 @@ the @code{define-markup-command} scheme macro."
       \override PaperColumn #'keep-inside-line = ##f
     }
   }
-
 }
Index: input/regression/relative-repeat.ly
diff --git a/input/regression/relative-repeat.ly b/input/regression/relative-repeat.ly index a8d3ac1ee7698c21117d33408cd609c5ca5ff6be..e84920d1f3012d6b26fcba2278002207a0ecee4d 100644
--- a/input/regression/relative-repeat.ly
+++ b/input/regression/relative-repeat.ly
@@ -1,10 +1,11 @@
 \header {
-  texidoc = "Relative mode for repeats uses order of entry."
+  texidoc = "Unfolded repeats take alternative notes in the order
+they appear in the alternative block."
   }
 \version "2.14.0"

-\relative c' {
-  \repeat "unfold" 3
-  { f2 bes2 }
-  \alternative { a1 e b }
+{
+  \clef "bass"
+  \repeat unfold 3 { f2^"Repeated notes" bes2 }
+  \alternative { a1_"Alt1" e_"Alt2" b_"Alt3" }
 }





reply via email to

[Prev in Thread] Current Thread [Next in Thread]