Re: Regtest changes phase 1 (issue 6454121)

[graham]

initial review of initial regtest changes.


http://codereview.appspot.com/6454121/diff/1/input/regression/context-mod-with.ly
File input/regression/context-mod-with.ly (right):

http://codereview.appspot.com/6454121/diff/1/input/regression/context-mod-with.ly#newcode4
input/regression/context-mod-with.ly:4: texidoc = "Context modifications
can be stored into a variable as a
this file looks much more complicated and should be reviewed by somebody
who knows about context modifications (i.e. not me)

http://codereview.appspot.com/6454121/diff/1/input/regression/markup-user.ly
File input/regression/markup-user.ly (right):

http://codereview.appspot.com/6454121/diff/1/input/regression/markup-user.ly#newcode16
input/regression/markup-user.ly:16: c''-\markup \upcase #"hello world in
upper case"
This file can be pushed directly to staging.

http://codereview.appspot.com/6454121/diff/1/input/regression/relative-repeat.ly
File input/regression/relative-repeat.ly (right):

http://codereview.appspot.com/6454121/diff/1/input/regression/relative-repeat.ly#newcode10
input/regression/relative-repeat.ly:10: \alternative { a1_"Alt1"
e_"Alt2" b_"Alt3" }
Isn't \alternative support to have the format
  { {first} {second} {third} }
?  I know that we can drop the inner {} if it's only a single note, but
IMO that isn't as safe as adding the {} and there's no harm in having
the inner {} explicitly.

Why is the \clef bass important?  Perhaps that should be mentioned in
the texidoc?

Why remove the \relative c' ?

http://codereview.appspot.com/6454121/