Re: convert-ly problem

[Trevor Daniels]

Marc Hohl wrote Tuesday, August 28, 2012 9:56 PM


> Am 28.08.2012 22:52, schrieb Graham Percival:
>> On Tue, Aug 28, 2012 at 10:45:00PM +0200, Marc Hohl wrote:
>>> Am 28.08.2012 20:52, schrieb David Kastrup:
>>>> Marc Hohl <address@hidden> writes:
>>>>
>>>>> After searching a bit more,
>>>>>
>>>>> git grep blank-page-force
>>>>>
>>>>> shows several hits, but in 2.17.x, this should read blank-page-penalty,
>>>>> so I assume when master gets updated, then the convert rules should be
>>>>> applied, or am I totally on the wrong track?
>>>> apparently somebody wrote the rule but did not
>>>> bother to run update-with-convert-ly and committing the result before
>>>> making a release.
>>> So can/shall I do something to correct this? I think this should be
>>> fixed quite soon, otherwise 'make doc' will fail for every language
>>> other than english, IIUC.
>> If there's syntax that hasn't been updated with
>> update-with-convert-ly, then it should definitely be updated.
>> However, apparently it didn't cause "make doc" to fail, since
>> 2.17.0 and 2.17.1 have been built.  (?)
>>
>> Regardless of that, please run update-with-convert-ly.  Assuming
>> the diff looks reasonable, please push directly to staging.  But
>> do manually check the diff (with gitk or any other git tool).
> Oh, this went parallel to me generating a rietveld patch.
> Can you have a quick glance at it?
> 
> Afterwards, I'll push to staging.

Marc, I've just logged on and seen this thread.  The fault is mine.  
I wrote the convert-ly rule, but omitted to follow it up with
update-with-convert-ly.  I'm sorry about that.  It was my first
convert-ly rule and foolishly I didn't check the CG to see what
should be done.  Many thanks for fixing it for me.

Trevor