Re: Allow direction - ^ _ before string indication \1, \2... (issue 6489074)

[dak]

Reviewers: janek,


http://codereview.appspot.com/6489074/diff/1/lily/parser.yy
File lily/parser.yy (right):

http://codereview.appspot.com/6489074/diff/1/lily/parser.yy#newcode2457
lily/parser.yy:2457: | string_number_event
On 2012/09/04 05:56:15, janek wrote:
> Why is this now in "direction_less_event"?  Does that name not imply
that things
> inside cannot have a direction?
> Maybe we should fix the naming?

No, it means that it is a post_event without a direction specifier
(yet).  I don't see this as inaccurate.

Description:
Allow direction - ^ _ before string indication \1, \2...

Please review this at http://codereview.appspot.com/6489074/

Affected files:
  M lily/parser.yy


Index: lily/parser.yy
diff --git a/lily/parser.yy b/lily/parser.yy
index  
35252bcb6e84f9fba33a6e6f2dbe43ef265286a0..b7d9df12140de7e098fa524a1f9a8d9231220f1c  
100644
--- a/lily/parser.yy
+++ b/lily/parser.yy
@@ -2379,7 +2379,6 @@ post_event_nofinger:
                }
                $$ = $2;
        }
-       | string_number_event
        | '^' fingering
        {
                $$ = $2;
@@ -2455,6 +2454,7 @@ direction_less_event:
                }
                $$ = m->unprotect ();
        }
+       | string_number_event
        | EVENT_IDENTIFIER      {
                $$ = $1;
        }