[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Uncommented code in LilyPond
From: |
Graham Percival |
Subject: |
Re: Uncommented code in LilyPond |
Date: |
Tue, 4 Sep 2012 12:24:11 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Sep 04, 2012 at 10:27:59AM +0200, address@hidden wrote:
>
> When I said that it'd be great for people to put /* TO COMMENT
> */, that is exactly the type of stuff I'd love to see in the
> code. Feel free to propose a patch with a bunch of /* TO
> COMMENT */ - I think if we mark these things, it'll make it
> easier to not waste time writing useless comments like the one
> in your do_sum example.
...
> I think Graham would agree with me
> in saying that people can push this stuff directly to staging w/o review.
I don't see how TO COMMENT will help, until we collectively learn
to write (and to *expect*) good comments. I would approach this
as a pedagogical issue, not a "mark places that need help" issue.
I think that being pickier with the reviews, possibly including
David's nice idea about only "replying" with updated patches, is
the best direction to move in.
- Graham
- Re: gerrit - does it allow writing commits using a web interface?, (continued)
- Re: gerrit - does it allow writing commits using a web interface?, David Kastrup, 2012/09/03
- Uncommented code in LilyPond, address@hidden, 2012/09/03
- Re: Uncommented code in LilyPond, David Kastrup, 2012/09/03
- Re: Uncommented code in LilyPond, address@hidden, 2012/09/03
- Re: Uncommented code in LilyPond, David Kastrup, 2012/09/03
- Re: Uncommented code in LilyPond, Janek Warchoł, 2012/09/03
- Re: Uncommented code in LilyPond, David Kastrup, 2012/09/03
- Re: Uncommented code in LilyPond, address@hidden, 2012/09/04
- Re: Uncommented code in LilyPond, Rodolfo Zitellini, 2012/09/04
- Re: Uncommented code in LilyPond, address@hidden, 2012/09/04
- Re: Uncommented code in LilyPond,
Graham Percival <=
- Re: Uncommented code in LilyPond, Janek Warchoł, 2012/09/04
- Re: Uncommented code in LilyPond, Graham Percival, 2012/09/04
- Re: Uncommented code in LilyPond, David Kastrup, 2012/09/04
- Re: Uncommented code in LilyPond, Graham Percival, 2012/09/03
- Re: Uncommented code in LilyPond, Janek Warchoł, 2012/09/03
- Re: Uncommented code in LilyPond, David Kastrup, 2012/09/03
Re: gerrit - does it allow writing commits using a web interface?, Janek Warchoł, 2012/09/03
Re: gerrit - does it allow writing commits using a web interface?, John Mandereau, 2012/09/06
Re: gerrit - does it allow writing commits using a web interface?, Jan Nieuwenhuizen, 2012/09/07