[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Uncommented code in LilyPond
From: |
Janek Warchoł |
Subject: |
Re: Uncommented code in LilyPond |
Date: |
Tue, 4 Sep 2012 13:46:28 +0200 |
On Tue, Sep 4, 2012 at 8:49 AM, address@hidden
<address@hidden> wrote:
> I started doing commenting in accidental.cc and accidental-engraver.cc.
> I found myself in the pattern of:
>
> [....]
>
> I still don't understand the utility of more comments in these two
> files after all of this.
Can you post what you have on Rietveld? I'll be glad to add my
"toComments" and "whys" there.
On Tue, Sep 4, 2012 at 1:24 PM, Graham Percival
<address@hidden> wrote:
> I think that being pickier with the reviews, possibly including
> David's nice idea about only "replying" with updated patches, is
> the best direction to move in.
Looks like i missed that part of the discussion... could you clarify
what do you mean by "replying only with updated patches"?
Janek
- Uncommented code in LilyPond, (continued)
- Uncommented code in LilyPond, address@hidden, 2012/09/03
- Re: Uncommented code in LilyPond, David Kastrup, 2012/09/03
- Re: Uncommented code in LilyPond, address@hidden, 2012/09/03
- Re: Uncommented code in LilyPond, David Kastrup, 2012/09/03
- Re: Uncommented code in LilyPond, Janek Warchoł, 2012/09/03
- Re: Uncommented code in LilyPond, David Kastrup, 2012/09/03
- Re: Uncommented code in LilyPond, address@hidden, 2012/09/04
- Re: Uncommented code in LilyPond, Rodolfo Zitellini, 2012/09/04
- Re: Uncommented code in LilyPond, address@hidden, 2012/09/04
- Re: Uncommented code in LilyPond, Graham Percival, 2012/09/04
- Re: Uncommented code in LilyPond,
Janek Warchoł <=
- Re: Uncommented code in LilyPond, Graham Percival, 2012/09/04
- Re: Uncommented code in LilyPond, David Kastrup, 2012/09/04
- Re: Uncommented code in LilyPond, Graham Percival, 2012/09/03
- Re: Uncommented code in LilyPond, Janek Warchoł, 2012/09/03
- Re: Uncommented code in LilyPond, David Kastrup, 2012/09/03
Re: gerrit - does it allow writing commits using a web interface?, Janek Warchoł, 2012/09/03
Re: gerrit - does it allow writing commits using a web interface?, John Mandereau, 2012/09/06
Re: gerrit - does it allow writing commits using a web interface?, Jan Nieuwenhuizen, 2012/09/07