Re: problem uploading a patch

[David Nalesnik]

Hi Phil.

> address@hidden ~/lilypond-git (dev/measure_counter)$ git cl issue 2445
> Issue number: 2445 (http://codereview.appspot.com/2445)
> address@hidden ~/lilypond-git (dev/measure_counter)$ git cl upload
> Unable to determine default branch to diff against.
> Either pass complete "git diff"-style arguments, like
>   git cl upload origin/master
> or verify this branch is set up to track another (via the --track argument to
> "git checkout -b ...").
> address@hidden ~/lilypond-git (dev/measure_counter)$ git cl
> upload origin/master
>  input/regression/measure-counter.ly |   41 ++++++++++++
>  ly/spanners-init.ly                 |    4 +
>  scm/define-event-classes.scm        |    6 +-
>  scm/define-grob-interfaces.scm      |    5 ++
>  scm/define-grob-properties.scm      |    1 +
>  scm/define-grobs.scm                |   18 +++++
>  scm/define-music-types.scm          |    5 ++
>  scm/music-functions.scm             |  117 
> +++++++++++++++++++++++++++++++++++
>  8 files changed, 194 insertions(+), 3 deletions(-)
> This branch is associated with issue 2445. Adding patch to that issue.
> Traceback (most recent call last):
>   File "/home/david/bin/git-cl", line 888, in <module>
>     sys.exit(main(sys.argv))
>   File "/home/david/bin/git-cl", line 882, in main
>     return func(argv[2:])
>   File "/home/david/bin/git-cl", line 584, in CmdUpload
>     desc = cl.GetDescription()
>   File "/home/david/bin/git-cl", line 278, in GetDescription
>     self.description = urllib2.urlopen(url).read().strip()
>   File "/usr/lib/python2.6/urllib2.py", line 126, in urlopen
>     return _opener.open(url, data, timeout)
>   File "/usr/lib/python2.6/urllib2.py", line 397, in open
>     response = meth(req, response)
>   File "/usr/lib/python2.6/urllib2.py", line 510, in http_response
>     'http', request, response, code, msg, hdrs)
>   File "/usr/lib/python2.6/urllib2.py", line 435, in error
>     return self._call_chain(*args)
>   File "/usr/lib/python2.6/urllib2.py", line 369, in _call_chain
>     result = func(*args)
>   File "/usr/lib/python2.6/urllib2.py", line 518, in http_error_default
>     raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
> urllib2.HTTPError: HTTP Error 404: Not Found
>

Looking into this further, I discovered a thread where Harm ran into a
similar situation:
http://www.mail-archive.com/address@hidden/msg47866.html

It's clearly not the same error, but it prompted me to look at the way
git cl is configured.  I get:

[core]
        repositoryformatversion = 0
        filemode = true
        bare = false
        logallrefupdates = true
[remote "origin"]
        url = git://git.sv.gnu.org/lilypond.git
        fetch = +refs/heads/master:refs/remotes/origin/master
[branch "master"]
        remote = origin
        merge = refs/heads/master
        rebase = true
[rietveld]
        server = codereview.appspot.com
        cc = address@hidden
[branch "dev/measure_counter"]
        rietveldissue = 2445
[gui]
        wmstate = normal


Is everything here OK?  I even tried adding http://  before the server
address, but this led to

[...]

File "/usr/lib/python2.6/httplib.py", line 682, in _set_hostport
    raise InvalidURL("nonnumeric port: '%s'" % host[i+1:])
httplib.InvalidURL: nonnumeric port: ''


No idea what to do :(

-David