lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 2917: Extend \keepWithTag to allow multiple tags (issue 674407


From: pkx166h
Subject: Re: Issue 2917: Extend \keepWithTag to allow multiple tags (issue 6744070)
Date: Wed, 24 Oct 2012 15:29:00 +0000

On 2012/10/24 10:07:25, dak wrote:
On 2012/10/24 09:58:12, janek wrote:
> LGTM
>
> shall the tracker issues "write doc for this"

It is not as much "write doc for this" as the function itself has its
docs
updated.  It is more "update the existing docs in the manual to
reflect the
change".

> and "add a regtest for this" be
> added now or after this patch is pushed?
> (my concern is to make sure that we won't forget)

I am not planning on working on this myself but that does not preclude
someone
else from submitting the respective parts which I would then
incorporate into
the patch.  So I would lean towards waiting with creating the
doc/regtest issues
until the patch is indeed being pushed.

NR Doc tracker is here

http://code.google.com/p/lilypond/issues/detail?id=2922

I think someone who knows better than I ought to make the regression
test.

James

https://codereview.appspot.com/6744070/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]