lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Updates to NR chapter 1 (issue 10237048)


From: dak
Subject: Re: Updates to NR chapter 1 (issue 10237048)
Date: Fri, 21 Jun 2013 14:11:20 +0000


https://codereview.appspot.com/10237048/diff/1/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):

https://codereview.appspot.com/10237048/diff/1/Documentation/notation/pitches.itely#newcode1316
Documentation/notation/pitches.itely:1316: \key c \freygish c4 des e f
I was actually surprised at the space being more or less the norm rather
than the exception.  However, the next line would then also be deserving
of that space.

In the tradition of "get offered a morsel, bite off the arm", let me
point out that
git grep '\\key [a-z]\+\\'
points out a few more contenders, including some more in this file:
Documentation/changes.tely:\clef bass \key es\major es g bes d
Documentation/changes.tely:\clef treble \bar "||" \key es\major es g bes
d
Documentation/changes.tely:\bar "||" \key d\major b fis b2
Documentation/es/changes.tely:\clef bass \key es\major es g bes d
Documentation/es/changes.tely:\clef treble \bar "||" \key es\major es g
bes d
Documentation/es/changes.tely:\bar "||" \key d\major b fis b2
Documentation/es/notation/input.itely:    \key c\minor
Documentation/es/notation/pitches.itely:  \key c\freygish c4 des e f
Documentation/es/notation/pitches.itely:  \bar "||" \key d\freygish d es
fis g
Documentation/es/notation/pitches.itely:\clef bass \key es\major es g
bes d
Documentation/es/notation/pitches.itely:\clef treble \bar "||" \key
es\major es g bes d
Documentation/es/notation/pitches.itely:\bar "||" \key b\major b fis b2
Documentation/fr/notation/input.itely:    \key c\minor
Documentation/fr/notation/pitches.itely:  \key c\freygish c4 des e f
Documentation/fr/notation/pitches.itely:  \bar "||" \key d\freygish d es
fis g
Documentation/fr/notation/pitches.itely:\clef bass \key es\major es g
bes d
Documentation/fr/notation/pitches.itely:\clef treble \bar "||" \key
es\major es g bes d
Documentation/fr/notation/pitches.itely:\bar "||" \key b\major b fis b2
Documentation/fr/notation/pitches.itely:  \key f\major
Documentation/included/engraver-example.ily:  \key d\major
Documentation/included/engraver-example.ily:  \key d\major
Documentation/it/notation/pitches.itely:  \key c\freygish c4 des e f
Documentation/it/notation/pitches.itely:  \bar "||" \key d\freygish d es
fis g
Documentation/it/notation/pitches.itely:\clef bass \key es\major es g
bes d
Documentation/it/notation/pitches.itely:\clef treble \bar "||" \key
es\major es g bes d
Documentation/it/notation/pitches.itely:\bar "||" \key b\major b fis b2
Documentation/ja/notation/pitches.itely:  \key c\freygish c4 des e f
Documentation/ja/notation/pitches.itely:  \bar "||" \key d\freygish d es
fis g
Documentation/ja/notation/pitches.itely:\clef bass \key es\major es g
bes d
Documentation/ja/notation/pitches.itely:\clef treble \bar "||" \key
es\major es g bes d
Documentation/ja/notation/pitches.itely:\bar "||" \key b\major b fis b2
Documentation/notation/input.itely:    \key c\minor
Documentation/notation/pitches.itely:  \key c\freygish c4 des e f
Documentation/notation/pitches.itely:  \bar "||" \key d\freygish d es
fis g
Documentation/notation/pitches.itely:\clef bass \key es\major es g bes d
Documentation/notation/pitches.itely:\clef treble \bar "||" \key
es\major es g bes d
Documentation/notation/pitches.itely:\bar "||" \key b\major b fis b2
Documentation/notation/pitches.itely:  \key f\major
Documentation/snippets/adding-links-to-objects.ly:  \key cis\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
input/regression/accidental-clef-change.ly:    \key g\major
input/regression/clip-systems.ly:      \key d\major
input/regression/grace-sync.ly:    \grace {  dis8[ ( d8] \key es\major
}
input/regression/key-signature-space.ly:    \key f\minor
input/regression/key-signature-space.ly:    \key b\major
input/regression/tuplet-full-length.ly:  \bar "|." \key c\minor

so there might be some incentive to factor all those out into one commit
spanning across all manuals and regtests.

https://codereview.appspot.com/10237048/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]