[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Build: Fix out-of-tree build from tarball. (issue 13854043)
|
From: |
julien . rioux |
|
Subject: |
Re: Build: Fix out-of-tree build from tarball. (issue 13854043) |
|
Date: |
Tue, 01 Oct 2013 10:34:17 +0000 |
https://codereview.appspot.com/13854043/diff/7001/Documentation/GNUmakefile
File Documentation/GNUmakefile (right):
https://codereview.appspot.com/13854043/diff/7001/Documentation/GNUmakefile#newcode283
Documentation/GNUmakefile:283: $(outdir)/contributor.texi:
$(outdir)/ly-grammar.txt
On 2013/10/01 10:27:08, dak wrote:
As mentioned in the comments: I don't think that contributor.texi
depends on
ly-grammar.txt: it just has a @verbatiminclude of it inside. So it
should be
that whatever depends on contributor.texi would also depend on
ly-grammar.txt.
Concretely: contributor.texi does not need to get rebuilt when
touching
ly-grammar.txt. I don't see a worse problem, though.
While that's technically true, my feeling is to go with the minimal
change to get the least surprises. Since this used to refer to
notation.texi, I simply changed it to notation.texi; this is easier to
do than typing multiple dependency rules for each output format, and
avoids the risk of missing one.
https://codereview.appspot.com/13854043/diff/7001/Documentation/de/GNUmakefile
File Documentation/de/GNUmakefile (right):
https://codereview.appspot.com/13854043/diff/7001/Documentation/de/GNUmakefile#newcode11
Documentation/de/GNUmakefile:11: $(outdir)/notation.texi:
$(outdir)/ly-grammar.txt
On 2013/10/01 10:27:08, dak wrote:
That gives us our own copy of ly-grammar.txt in the German
documentation, right?
right.
https://codereview.appspot.com/13854043/