Re: note-spacing: pad accidentals from neighbor as far as from parent; issue 3869 (issue 65260044)

[k-ohara5a5a]

Reviewers: janek,

Message:
On 2014/02/20 22:21:37, janek wrote:
> I would add a comment
> "TODO: this hard-coded value should be removed when
> http://code.google.com/p/lilypond/issues/detail?id=2142
> will be taken care of"

What does 'hard-coded' mean here?
If there is a setting of 'padding' padding it gets used.  If there is no
setting at all, 0.2 is used instead.
After you fix issue 2142 and remove the value, if make some input where
I set padding to empty '() or ##f or something, what will happen?

Description:
note-spacing: pad accidentals from neighbor as far as from parent; issue
3869

Change the default in the C code, rather than define-grobs.scm, because
it is surprising which grob type, NonMusicalPaperColumn, controls this
padding.

Please review this at https://codereview.appspot.com/65260044/

Affected files (+1, -1 lines):
  M lily/spacing-spanner.cc


Index: lily/spacing-spanner.cc
diff --git a/lily/spacing-spanner.cc b/lily/spacing-spanner.cc
index  
2f2724689d6e99cf1493fd3259694d2eec34547b..624ce6fb9ec01b95478b990ed28b73fb3f828d76  
100644
--- a/lily/spacing-spanner.cc
+++ b/lily/spacing-spanner.cc
@@ -302,7 +302,7 @@ Spacing_spanner::generate_springs (Grob *me,
       prev = col;
     }

-  Real padding = robust_scm2double (prev->get_property ("padding"), 0.1);
+  Real padding = robust_scm2double (prev->get_property ("padding"), 0.2);
   set_column_rods (cols, padding);
 }