[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Generate a .pe script for one design size at a time. (issue 93430043
From: |
David Kastrup |
Subject: |
Re: Generate a .pe script for one design size at a time. (issue 93430043) |
Date: |
Tue, 20 May 2014 21:58:28 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) |
Han-Wen Nienhuys <address@hidden> writes:
> what's the procedure for pushing this after the LGTM? Can I just push
> the commit onto master?
>
> On Sun, May 18, 2014 at 6:38 PM, <address@hidden> wrote:
>> LGTM now, thanks.
>>
>> https://codereview.appspot.com/93430043/
LGTM is just a thumbs-up from one reviewer. If the review looks
favorably, the patch will be promoted to Patch-push status by the Patch
meister eventually. That's when one can rebase and push the patch to
staging (never! master) and mark the issue as fixed. Automated
procedures will do a complete check of staging regularly (every few
hours) and push it to master when it passes all of a number of checks.
--
David Kastrup