Re: Add chord range to make-part-combine-music (issue 144170043 by address@hidden)

[dak]

On 2014/09/19 13:20:41, Dan Eble wrote:
> On 2014/09/19 11:20:55, dak wrote:
> > I think that's the kind of thing much better put into a context
property.  It

> I see that recording-group-emulate calls (ly:context-property child
> 'instrumentTransposition)).  Should I look to that as an example?

> > can change over the course of one partcombine

> I would never use that feature.  It would also complicate
implementation and
> testing.

> > parameter that we do not want to pass up and down all the time since
it is
> just
> > one of many possibly interesting parameters for which we do not want
to
> redesign
> > interfaces any time a new one gets added.

> I agree.  Would you say the same about the "direction" parameter or is
it
> exceptional?

I would say the same about the direction parameter.  And the key, and
the clef.  And particular forced partcombiner decisions.  I have several
unfinished branches in my repository that are concerned with ripping out
the ridiculous amount of \partCombine commands that still don't result
in flexible ways of combining parts (like using \voiceThree and
\voiceFour instead of \voiceOne and \voiceTwo) and replace them with
optional context modifications and context properties.  Before I parked
work on <URL:https://code.google.com/p/lilypond/issues/detail?id=1321>,
it was going in that direction as well.

If you want to, I can rebase the respective branches on current master
and push them into the central repository, and you can see whether you
want to pick up work on them.

https://codereview.appspot.com/144170043/