lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 4212: fix out-of-bounds index in division_maior() (issue 18942


From: benko . pal
Subject: Re: Issue 4212: fix out-of-bounds index in division_maior() (issue 189420043 by address@hidden)
Date: Thu, 01 Jan 2015 22:57:30 +0000


https://codereview.appspot.com/189420043/diff/1/lily/breathing-sign.cc
File lily/breathing-sign.cc (right):

https://codereview.appspot.com/189420043/diff/1/lily/breathing-sign.cc#newcode122
lily/breathing-sign.cc:122: if (ydim[DOWN] < val && line_pos.begin () <
it - 1)
I'd rather write
line_pos.begin () + 1 < it
but good catch anyway, thanks!

https://codereview.appspot.com/189420043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]