Re: Issue 4212: fix out-of-bounds index in division_maior() (issue 189420043 by address@hidden)

[nine . fierce . ballads]

On 2015/01/01 22:57:31, benko.pal wrote:
> https://codereview.appspot.com/189420043/diff/1/lily/breathing-sign.cc
> File lily/breathing-sign.cc (right):


https://codereview.appspot.com/189420043/diff/1/lily/breathing-sign.cc#newcode122
> lily/breathing-sign.cc:122: if (ydim[DOWN] < val && line_pos.begin ()
< it - 1)
> I'd rather write
> line_pos.begin () + 1 < it
> but good catch anyway, thanks!

I also find the whole surrounding code difficult to read, but I don't
want to spend any more time on this than I have to.  Thanks for the
feedback.

https://codereview.appspot.com/189420043/