[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Reduce size of PDF files when inc. in *TeX docs (issue 194090043 by
From: |
lemzwerg |
Subject: |
Re: Reduce size of PDF files when inc. in *TeX docs (issue 194090043 by address@hidden) |
Date: |
Sat, 10 Jan 2015 10:02:07 +0000 |
LGTM, thanks! I only have some minor comments regarding improved
legibility of the source code.
https://codereview.appspot.com/194090043/diff/1/Documentation/de/usage/running.itely
File Documentation/de/usage/running.itely (right):
https://codereview.appspot.com/194090043/diff/1/Documentation/de/usage/running.itely#newcode160
Documentation/de/usage/running.itely:160: pdftex-, xetex-, oder
luatex-Dokumente eingebettet werden,
I would end this line with `;' or `:' instead of a comma.
https://codereview.appspot.com/194090043/diff/1/ps/encodingdefs.ps
File ps/encodingdefs.ps (right):
https://codereview.appspot.com/194090043/diff/1/ps/encodingdefs.ps#newcode8
ps/encodingdefs.ps:8: /LilyNoteHeadEncoding [ /.notdef
/noteheads.d0doFunk /noteheads.d0fa
For better orientation, please reformat this to have a fixed number of
entries per line (I suggest 4 items), together with comments that
indicate the current index (something like `% 0x50').
https://codereview.appspot.com/194090043/diff/1/ps/encodingdefs.ps#newcode91
ps/encodingdefs.ps:91: /noteheads.d0doFunk {<01> show} def
/noteheads.d0fa {<02> show} def
Here, I would prefer one entry per line.
https://codereview.appspot.com/194090043/diff/1/ps/encodingdefs.ps#newcode214
ps/encodingdefs.ps:214: /LilyScriptEncoding [ /.notdef
/clefs.blackmensural.c
The same comment as above.
https://codereview.appspot.com/194090043/diff/1/scm/output-ps.scm
File scm/output-ps.scm (right):
https://codereview.appspot.com/194090043/diff/1/scm/output-ps.scm#newcode126
scm/output-ps.scm:126: (ly:format "currentpoint ~4f ~4f rmoveto ~a
moveto ~4f 0 rmoveto" x y g w)))
Please reformat this (and similar) code to stay within the
80-characters-per-line limit if possible.
https://codereview.appspot.com/194090043/
- Re: Reduce size of PDF files when inc. in *TeX docs (issue 194090043 by address@hidden), pkx166h, 2015/01/09
- Re: Reduce size of PDF files when inc. in *TeX docs (issue 194090043 by address@hidden),
lemzwerg <=
- Re: Reduce size of PDF files when inc. in *TeX docs (issue 194090043 by address@hidden), pkx166h, 2015/01/11
- Re: Reduce size of PDF files when inc. in *TeX docs (issue 194090043 by address@hidden), lemzwerg, 2015/01/11
- Re: Reduce size of PDF files when inc. in *TeX docs (issue 194090043 by address@hidden), lemzwerg, 2015/01/11
- Re: Reduce size of PDF files when inc. in *TeX docs (issue 194090043 by address@hidden), pkx166h, 2015/01/11
- Re: Reduce size of PDF files when inc. in *TeX docs (issue 194090043 by address@hidden), lemzwerg, 2015/01/12
- Re: Reduce size of PDF files when inc. in *TeX docs (issue 194090043 by address@hidden), lemzwerg, 2015/01/12
- Re: Reduce size of PDF files when inc. in *TeX docs (issue 194090043 by address@hidden), pkx166h, 2015/01/12
- Re: Reduce size of PDF files when inc. in *TeX docs (issue 194090043 by address@hidden), lemzwerg, 2015/01/14