Re: Reduce size of PDF files when inc. in *TeX docs (issue 194090043 by address@hidden)

[pkx166h]

Thanks


https://codereview.appspot.com/194090043/diff/1/Documentation/de/usage/running.itely
File Documentation/de/usage/running.itely (right):

https://codereview.appspot.com/194090043/diff/1/Documentation/de/usage/running.itely#newcode160
Documentation/de/usage/running.itely:160: pdftex-, xetex-, oder
luatex-Dokumente eingebettet werden,
On 2015/01/10 10:02:07, lemzwerg wrote:
> I would end this line with `;' or `:' instead of a comma.

Done.

https://codereview.appspot.com/194090043/diff/1/ps/encodingdefs.ps
File ps/encodingdefs.ps (right):

https://codereview.appspot.com/194090043/diff/1/ps/encodingdefs.ps#newcode8
ps/encodingdefs.ps:8: /LilyNoteHeadEncoding [ /.notdef
/noteheads.d0doFunk /noteheads.d0fa
On 2015/01/10 10:02:07, lemzwerg wrote:
> For better orientation, please reformat this to have a fixed number of
entries
> per line (I suggest 4 items),

I did 3 items maximum and kept things within the line length.

> together with comments that indicate the current
> index (something like `% 0x50').

Werner, I don't understand what you mean by "...together with comments
that indicate the current index (something like `% 0x50')."

As I am helping shepherd this patch and because of problems with Knut's
patch applying if this is something you can easily explain to me I can
do this for Knut and save some time for the patch.

https://codereview.appspot.com/194090043/diff/1/ps/encodingdefs.ps#newcode91
ps/encodingdefs.ps:91: /noteheads.d0doFunk {<01> show} def
/noteheads.d0fa {<02> show} def
On 2015/01/10 10:02:07, lemzwerg wrote:
> Here, I would prefer one entry per line.

Done.

https://codereview.appspot.com/194090043/diff/1/ps/encodingdefs.ps#newcode214
ps/encodingdefs.ps:214: /LilyScriptEncoding [ /.notdef
/clefs.blackmensural.c
On 2015/01/10 10:02:07, lemzwerg wrote:
> The same comment as above.

Done.

https://codereview.appspot.com/194090043/diff/1/scm/output-ps.scm
File scm/output-ps.scm (right):

https://codereview.appspot.com/194090043/diff/1/scm/output-ps.scm#newcode126
scm/output-ps.scm:126: (ly:format "currentpoint ~4f ~4f rmoveto ~a
moveto ~4f 0 rmoveto" x y g w)))
On 2015/01/10 10:02:07, lemzwerg wrote:
> Please reformat this (and similar) code to stay within the
> 80-characters-per-line limit if possible.

Hope this is better (I don't code so am not sure if there are specific
'rules' about how scm is formatted here.

https://codereview.appspot.com/194090043/