Re: Articulate.ly: Fix mordent and prall timing for short notes (issue 190530043 by address@hidden)

[pkx166h]

On 2015/01/21 22:04:27, peter_chubb.wattle.id.au wrote:
> >>>>> "pkx166h" == pkx166h  <mailto:address@hidden> writes:

> pkx166h> On 2015/01/20 22:08:16, Peter Chubb wrote:
> >> articulate.ly: Fix \trillSpan problem

> pkx166h> Peter, I can see 4 patches uploaded here but it looks like
> pkx166h> from the time stamps that this was some git-cl error or
> pkx166h> something similar?

> There was supposed to be only one.
>        git format-patch origin
>       yields:

>  From 47e8cd08748e2d1d00a725148511f8290eed8f8e Mon Sep 17 00:00:00 2001
> From: Peter Chubb <mailto:address@hidden>
> Date: Wed, 21 Jan 2015 08:18:19 +1100
> Subject: [PATCH] Fix trill-span errors

> The last change introduced a bug: ac:twiddletime returns a moment, and
it
> was changed to return a duration.  This causes a lilypond error when
> using trillspan and articulate.
> ---
>   ly/articulate.ly | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

> diff --git a/ly/articulate.ly b/ly/articulate.ly
> index 706c57c..bbfea19 100644
> --- a/ly/articulate.ly
> +++ b/ly/articulate.ly
> @@ -347,11 +347,11 @@
>               (ly:music-property music 'elements)))
>          (pre-t (if (pair? tr) (ly:music-property (car tr) 'twiddle)
>                  '()))
> -        (hemisemidur (ly:make-duration 5 0 1/1))
> +        (hemisemimom (ly:make-moment 1/64))
>          (t (ac:targetTwiddleTime)))
>      (if (ly:moment? pre-t)
>       pre-t
> -    hemisemidur)))
> +    hemisemimom)))



> --
> 2.1.4


OK thanks. I have created a new tracker for this and will test/manage
the fix using it:

https://code.google.com/p/lilypond/issues/detail?id=4270&thanks=4270

so we have coherent issue history (at least from my point of view when
trying to manage the patches for testing).

As and when this is ready to push, could you change the commit message
accordingly? Again just so that everyone can follow this in git from an
historical perspective and we don't have two checkins that have
identical commit messages for different 'fixes'.

Thanks

James

I'll re-use this

https://codereview.appspot.com/190530043/