[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Allow independent adjustment of minimum length for spanner siblings
From: |
david . nalesnik |
Subject: |
Re: Allow independent adjustment of minimum length for spanner siblings (issue 201140043 by address@hidden) |
Date: |
Fri, 06 Feb 2015 20:08:21 +0000 |
https://codereview.appspot.com/201140043/diff/20001/lily/spanner.cc
File lily/spanner.cc (right):
https://codereview.appspot.com/201140043/diff/20001/lily/spanner.cc#newcode404
lily/spanner.cc:404: Rod r;
Perhaps we should call this rod something else to underscore that it's
not the same rod as the one declared above. Sure, it's fine because the
last r was declared in a nested scope and "'r' is for rod!", but this is
unnecessarily confusing (even after moving the declaration from where it
was originally, which was really obscure).
https://codereview.appspot.com/201140043/
- Re: Allow independent adjustment of minimum length for spanner siblings (issue 201140043 by address@hidden), thomasmorley65, 2015/02/05
- Re: Allow independent adjustment of minimum length for spanner siblings (issue 201140043 by address@hidden), david . nalesnik, 2015/02/05
- Re: Allow independent adjustment of minimum length for spanner siblings (issue 201140043 by address@hidden), thomasmorley65, 2015/02/05
- Re: Allow independent adjustment of minimum length for spanner siblings (issue 201140043 by address@hidden), lemzwerg, 2015/02/06
- Re: Allow independent adjustment of minimum length for spanner siblings (issue 201140043 by address@hidden), david . nalesnik, 2015/02/06
- Re: Allow independent adjustment of minimum length for spanner siblings (issue 201140043 by address@hidden),
david . nalesnik <=
- Re: Allow independent adjustment of minimum length for spanner siblings (issue 201140043 by address@hidden), lemzwerg, 2015/02/06
- Re: Allow independent adjustment of minimum length for spanner siblings (issue 201140043 by address@hidden), david . nalesnik, 2015/02/08
- Re: Allow independent adjustment of minimum length for spanner siblings (issue 201140043 by address@hidden), thomasmorley65, 2015/02/09