[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Clean up inconsistencies in engraver-init.ly and performer-init.ly (
|
From: |
thomasmorley65 |
|
Subject: |
Re: Clean up inconsistencies in engraver-init.ly and performer-init.ly (issue 199460043 by address@hidden) |
|
Date: |
Mon, 09 Feb 2015 23:46:45 +0000 |
On 2015/02/09 06:09:34, lemzwerg wrote:
LGTM. It would be nice if David's checker script could be added, too.
More, I'd consider it a good idea to use the checker on the current
patch again.
There was such a mess that I'm not sure I corrected all.
https://codereview.appspot.com/199460043/diff/20001/ly/performer-init.ly
File ly/performer-init.ly (right):
https://codereview.appspot.com/199460043/diff/20001/ly/performer-init.ly#newcode174
ly/performer-init.ly:174: \accepts ChordNames
I wonder whether it makes sense to sort the many \accept lines
alphabetically...
I'd happily do it, though, why alpabetically? And why only for the lines
with \accept, could be done for the context-defs as well.
And it's also thinkable to sort it following context-hierarchy: first
bottom-contexts like Voice, then Staff up to Score and Global.
Or vice versa...
What do others think?
https://codereview.appspot.com/199460043/