|
| From: | dak |
| Subject: | Re: Decrease space between vertical beams by length-fraction. (issue 214250043 by address@hidden) |
| Date: | Tue, 24 Mar 2015 12:01:30 +0000 |
https://codereview.appspot.com/214250043/diff/40001/lily/beam.cc File lily/beam.cc (right): https://codereview.appspot.com/214250043/diff/40001/lily/beam.cc#newcode127 lily/beam.cc:127: ? (2 * staff_space + line - beam_thickness/fract) / 2.0 Is there some point to writing the stuff in a manner where the result comes about by a lot of cancellation? Here we have (2 * staff_space + line - beamthickness/fract) / 2.0 * fract instead of either (staff_space + line/2.0)*fract - beamthickness/2.0 or staff_space*fract + (line*fract - beamthickness)/2.0 and I don't see that we get better results by all that cancellation. Also it becomes fragile against things like fract being zero. https://codereview.appspot.com/214250043/
| [Prev in Thread] | Current Thread | [Next in Thread] |