Re: Remove unused event-type general-music (issue 222090043 by address@hidden)

[david . nalesnik]

https://codereview.appspot.com/222090043/diff/1/scm/define-music-types.scm
File scm/define-music-types.scm (right):

https://codereview.appspot.com/222090043/diff/1/scm/define-music-types.scm#newcode343
scm/define-music-types.scm:343: (types . ())
On 2015/04/04 15:25:27, Trevor Daniels wrote:
> On 2015/04/01 15:16:07, david.nalesnik wrote:
> > Should Music be given a type? According to pattern, "music" with
lowercase
> "m"?

> Well, if "general-music" is unused presumably a type of "music" would
also be
> unused.  I'm rather outside my knowledge zone here, but is an entry of
Music
> required at all?  If "general-music" is being removed I'd have thought
the Music
> entry should be removed too.

> Trevor

Music is used.  For example, looking at what sort of object must be
produced by \shape:

#(display (car (ly:music-function-signature shape)))

==>

(#<primitive-procedure ly:music?> . #<Prob: Music C++: Music((void .
#t))((name . Music) (types general-music)) >
)

This patch would leave an empty entry for types.  That doesn't matter
here -- The predicate ly:music? works just fine.  I just wonder if there
would ever be cause to recognize Music by its types, as for example, a
engraver would recognize NoteEvent by note-event.

https://codereview.appspot.com/222090043/