lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add stencil-flip function (issue 235090043 by address@hidden)


From: lemzwerg
Subject: Re: Add stencil-flip function (issue 235090043 by address@hidden)
Date: Wed, 06 May 2015 06:01:30 +0000


https://codereview.appspot.com/235090043/diff/40001/scm/stencil.scm
File scm/stencil.scm (right):

https://codereview.appspot.com/235090043/diff/40001/scm/stencil.scm#newcode668
scm/stencil.scm:668: An @var{axis} of Y or 1 will flip it vertically.
What about:

  Value @code{X} (or @code{0}) for @var{axis} flips it horizontally.
  Value @code{Y} (or @code{1}) flips it vertically.

Exactly defined values for a variable should be represented with
address@hidden'.  And I'm a great fan of avoiding future tense in documentation
:-)

https://codereview.appspot.com/235090043/diff/40001/scm/stencil.scm#newcode669
scm/stencil.scm:669: @var{stil} is flipped in place.  Its position, the
I suggest s/./;/

https://codereview.appspot.com/235090043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]