Re: Issue 4495 Remove unnecessary #{ .. #} constructs (issue 253310043 by address@hidden)

[tdanielsmusic]

Thanks David


https://codereview.appspot.com/253310043/diff/1/ly/staff-tkit.ly
File ly/staff-tkit.ly (right):

https://codereview.appspot.com/253310043/diff/1/ly/staff-tkit.ly#newcode60
ly/staff-tkit.ly:60: #(if dynUp
On 2015/07/18 22:02:54, dak wrote:
> elseif cascades are bad to read in Scheme's indentation.  Rather use
cond here:

> #(cond (dynUp dynamicUp)
>         (dynDown dynamicDown)
>         (else dynamicNeutral))

Done.  Here and elsewhere.

https://codereview.appspot.com/253310043/diff/1/ly/vocal-tkit.ly
File ly/vocal-tkit.ly (right):

https://codereview.appspot.com/253310043/diff/1/ly/vocal-tkit.ly#newcode41
ly/vocal-tkit.ly:41: (if v1music
On 2015/07/18 22:02:54, dak wrote:
> This does not work.  #{ << #*unspecified* >> #} ignores the given
element, but
> (make-simultanous-music (list ... will not do so.

> Instead do something like
> (delq! #f
>    (list
>      (make-two-voice-staff name clef v1name v2name)
>      (and v1music ...)
>      (and v2music ...)))

Done.  Aaannd ... this fixed the doc failure notified by James/Patchy
last time.  Thanks.

https://codereview.appspot.com/253310043/