[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Carry multi-measure rests across voices in \partcombine (issue 26541
From: |
nine . fierce . ballads |
Subject: |
Re: Carry multi-measure rests across voices in \partcombine (issue 265410043 by address@hidden) |
Date: |
Thu, 08 Oct 2015 22:09:32 +0000 |
https://codereview.appspot.com/265410043/diff/60001/lily/part-combine-iterator.cc
File lily/part-combine-iterator.cc (right):
https://codereview.appspot.com/265410043/diff/60001/lily/part-combine-iterator.cc#newcode146
lily/part-combine-iterator.cc:146: // get_event_length(), which reads
"length"?
On 2015/10/08 12:07:42, Trevor Daniels wrote:
Perhaps this question should be resolved before pushing.
That'll teach me to raise questions about the existing implementation.
If someone can help answer this and explain that a specific and simple
change is desirable, I'd be happy to take action. Otherwise, I'd be
willing to retract the comment before pushing. Otherwise, this patch is
going to be delayed until I have more time.
https://codereview.appspot.com/265410043/
- Re: Carry multi-measure rests across voices in \partcombine (issue 265410043 by address@hidden), nine . fierce . ballads, 2015/10/08
- Re: Carry multi-measure rests across voices in \partcombine (issue 265410043 by address@hidden), tdanielsmusic, 2015/10/09
- Re: Carry multi-measure rests across voices in \partcombine (issue 265410043 by address@hidden),
nine . fierce . ballads <=
- Re: Carry multi-measure rests across voices in \partcombine (issue 265410043 by address@hidden), dak, 2015/10/09
- Re: Carry multi-measure rests across voices in \partcombine (issue 265410043 by address@hidden), nine . fierce . ballads, 2015/10/09
- Re: Carry multi-measure rests across voices in \partcombine (issue 265410043 by address@hidden), dak, 2015/10/10
- Re: Carry multi-measure rests across voices in \partcombine (issue 265410043 by address@hidden), nine . fierce . ballads, 2015/10/10
- Re: Carry multi-measure rests across voices in \partcombine (issue 265410043 by address@hidden), dak, 2015/10/10
- Re: Carry multi-measure rests across voices in \partcombine (issue 265410043 by address@hidden), dak, 2015/10/10
- Re: Carry multi-measure rests across voices in \partcombine (issue 265410043 by address@hidden), nine . fierce . ballads, 2015/10/11