Re: Carry multi-measure rests across voices in \partcombine (issue 265410043 by address@hidden)

[nine . fierce . ballads]

On 2015/10/09 06:23:09, dak wrote:


https://codereview.appspot.com/265410043/diff/60001/lily/part-combine-iterator.cc#newcode144
> lily/part-combine-iterator.cc:144: // What is the relationship between
> "duration" and "length"?  Why does
> Length is a Moment, duration is a Duration.  get_event_length converts
a
> Duration into a Moment and caches the result.  Moments are what the
general
> timing works with.

> So there is really nothing to be seen here.

By what process should get_event_length() convert a duration to a
moment?  All I see in get_event_length() is a call to get the "length"
property.

When I change my start_mmrest() to set "duration" instead of "length",
the bug in part-combine-solo-end.ly reappears.  I am using
Duration().compressed(length.main_part_).smobbed_copy() as the duration.


https://codereview.appspot.com/265410043/