[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: stencil.scm: make args optional in stencil-whiteout (issue 284980043
From: |
paulwmorris |
Subject: |
Re: stencil.scm: make args optional in stencil-whiteout (issue 284980043 by address@hidden) |
Date: |
Mon, 04 Jan 2016 05:19:20 +0000 |
Addressing Harm's suggestions in patch set 2.
https://codereview.appspot.com/284980043/diff/1/scm/stencil.scm
File scm/stencil.scm (right):
https://codereview.appspot.com/284980043/diff/1/scm/stencil.scm#newcode804
scm/stencil.scm:804: (define*-public (stencil-whiteout stil #:optional
(style 'box)
On 2016/01/03 23:14:22, thomasmorley651 wrote:
I like it optional.
But why do you give default-values for style and thickness? If you'd
do:
#:optional style thickness (line-thickness 0.1)
then style and thickness default to #f, would be sufficient.
Good point! I'll make that change.
Though the doc-string needs to be changed then, maybe something at the
lines of:
[...]
Please check spelling, grammar and wording, though. I'm not a native
speaker
Will do, and thanks for the text suggestions. See how you like the
version in patch set 2.
https://codereview.appspot.com/284980043/
- Re: stencil.scm: make args optional in stencil-whiteout (issue 284980043 by address@hidden),
paulwmorris <=