Re: Musicxml2ly: Fix incorrect conversion of Minor Chords (issue 305700043 by address@hidden)

[pkx166h]

On 2016/10/07 17:31:40, jvromans_squirrel.nl wrote:
> On Fri, 07 Oct 2016 07:45:53 -0700
> mailto:address@hidden wrote:

> > https://codereview.appspot.com/305700043/diff/1/python/musicexp.py
> > File python/musicexp.py (right):
> >
> >

https://codereview.appspot.com/305700043/diff/1/python/musicexp.py#newcode1608
> > python/musicexp.py:1608: # digit. If none, omit the ".".
> > I think this behavior is wrong since the first digit is _not_ a mere
> > addition but determines the "stacking height" of the preceding
chord.
> > See, for example, the output of
> >
> > \chordmode { c:dim3.5.13 c:dim13 }
> >
> > for the difference.

> Yes, that's right.

> Cdim13 (in MuseScore) becomes MusicXML C + dim7 + 9 + 11 + 13.

> Cdim(add13) becomes C + dim + 13. This would then be translated to
Cdim13.

> > The pattern \d$ also is not sufficient since it
> > does not cover 5- (for example).  Maybe something like r':.*?\d'
would
> > do the trick?

> The bottom line is: What is required in chord c:blah so that .NN can
be
> added as a pure addition. It is unfortunate that c:.13 is invalid
syntax.

> While we're at it: A couple of lines later (line 1617):

>          if self.bass:
>              value += "/+%s" % self.bass.ly_expression ()

> AFAIK, a bass note is written as /c, not /+c.

> Thanks for chiming in!

> -- Johan
Johan,

Does this mean you are going to provide a new patch or something else?

James


https://codereview.appspot.com/305700043/