lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Implement extra-offset for system positioning (issue 324810043 by ad


From: thomasmorley65
Subject: Re: Implement extra-offset for system positioning (issue 324810043 by address@hidden)
Date: Fri, 28 Apr 2017 02:26:33 -0700

Some nits, otherwise LGTM
Worth an entry in changes?



https://codereview.appspot.com/324810043/diff/1/input/regression/page-layout-extra-offset.ly
File input/regression/page-layout-extra-offset.ly (right):

https://codereview.appspot.com/324810043/diff/1/input/regression/page-layout-extra-offset.ly#newcode7
input/regression/page-layout-extra-offset.ly:7: printable area of the
page or the absolute position pecified by
typo
pecified->specified

https://codereview.appspot.com/324810043/diff/1/scm/page.scm
File scm/page.scm (right):

https://codereview.appspot.com/324810043/diff/1/scm/page.scm#newcode246
scm/page.scm:246: (extra-offset (ly:prob-property system 'extra-offset
(cons 0 0)))
Why not directly '(0 . 0) instead of constructing it?
Admittedly, starting with guile-2.2 set-car! (and similiar) will error
on literals, though this is not the case here.

https://codereview.appspot.com/324810043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]