Re: Implement extra-offset for system positioning (issue 324810043 by address@hidden)

[david . nalesnik]

On 2017/04/28 22:24:57, david.nalesnik wrote:
> On 2017/04/28 16:15:42, david.nalesnik wrote:
> > On 2017/04/28 15:50:52, dak wrote:
> > > Does an extra-offset in X direction even make sense when the
systems are
> > spaced
> > > according to their skylines _before_ the extra-offset is applied?
> >
> > Well, X-offset of line-break-system-details is applied in
make-page-stencil,
> > too.

> In any case, having an extra-offset in the Y direction is obviously
much more
> useful.  Extra-offset in the X direction seems a bit superfluous,
since it's
> easy enough to set 'X-offset based on the left edge of the printing
space.

Or, rather, I would imagine that the extra-offset setting for X would be
the same as X-offset....

> My
> original code created an extra-Y-offset, and I'm happy to go back to
this.

> Opinions?



https://codereview.appspot.com/324810043/